Netgear R7800 exploration (IPQ8065, QCA9984)

http://lists.infradead.org/pipermail/ath10k/2018-February/010814.html

so this is the patch but i can't see support for ipq8065 board

LED definitions of an individual board/chip are not part of the upstream ath10k wifi driver.

You have to take the model from the dd-wrt site...

Likely this (just the addition, not the removal of the earlier board-spcific additions)
http://svn.dd-wrt.com/changeset/34991

We will have to experiment a bit.

It works, at least partially.
After applying the patch from Brainslayer, I get the one of the wifi LEDs to work.

Both LEDs are visible in console, but only one of them shows activity in R7800.

root@OpenWrt:~# ls /sys/class/leds/
ath10k-phy0        r7800:amber:power  r7800:white:esata  r7800:white:usb1   r7800:white:wan    r7800:white:wps
ath10k-phy1        r7800:amber:wan    r7800:white:power  r7800:white:usb2   r7800:white:wifi

root@OpenWrt:~# ls /sys/class/leds/ath10k-phy0/
brightness      max_brightness  subsystem       trigger         uevent

root@OpenWrt:~# cat /sys/class/leds/ath10k-phy0/trigger
none switch0 timer default-on netdev usbport phy0rx phy0tx phy0assoc phy0radio [phy0tpt] phy1rx phy1tx phy1assoc phy1radio phy1tpt

root@OpenWrt:~# cat /sys/class/leds/ath10k-phy1/trigger
none switch0 timer default-on netdev usbport phy0rx phy0tx phy0assoc phy0radio phy0tpt phy1rx phy1tx phy1assoc phy1radio [phy1tpt]

Note that Brainslayer's first emailed patch was malformed, and now the fourth seems to be applicable except for a non-existing ubiquiti definition.

I got the Wifi LEDs to work partially in R7800.

With these patches, the 5GHz LED works ok, but 2.4GHz LEDE does not show any signs of life.

There is:

  • patch for LEDE definitions in target/linux/ipq806x/base-files/etc/board.d/01_leds
  • clean version of package/kernel/mac80211/patches/970-ath10k-QCA-LED-support.patch that is Brainslayer's patch (minus a definition for ubiquiti)
  • alternative patch to create 970-ath10k-QCA... using patch command

Brainslayer's patch does not apply cleanly, so I removed the non-existing ubiquiti section plus refreshed the context.

Otiginal patch: http://lists.infradead.org/pipermail/ath10k/2018-February/010817.html

someone should report that the 2.4 led doesn't work... does it work in dd-wrt?

Well, he posted the patch for the ath10k HEAD while we use a bit older backported version. possibly something different, so it might not be a fault in the upstream patch.

Feel free to experiment and to try to find the reason in your own builds.

echo phy0tpt > /sys/class/leds/ath10k-phy0/trigger
echo phy1tpt > /sys/class/leds/ath10k-phy1/trigger

Yes?
I patched that directly to the LED definitions, and the end result (shown in Netgear R7800 exploration (IPQ8065, QCA9984) - #806 by hnyman ) is the same as by echoing it manually.

Did you get both LEDs to work?

Someone did report the LEDs not working, despite them being added in, as shown here in this ticket. However, shortly after that, I'm seeing more commits from Brainslayer, some pertaining to the LEDs.

Sorry, didn't notice :slight_smile: I can't test anymore, I've sold my device today

Oops.
Does that mean that there will be no R7800 work coming from you, any more? Would be sad.

yep very sad

Well, actually r7800 is done as it seems and there's nothing more to be added besides blogic's dsa patches, so not a big loss :slight_smile:
My last 2 PRs still reside on the list and I have 1 more fabrics scaling improvement left. Will update the fabrics scaling PR later.

Btw there seem to be an updated version of ath10k patch
https://patchwork.kernel.org/patch/10221563/

The final version has actually not got on to Patchwork, (as the sender address is not right.)
I used the last version that he sent:
http://lists.infradead.org/pipermail/ath10k/2018-February/date.html
http://lists.infradead.org/pipermail/ath10k/2018-February/010817.html

Looks like Brainslayer has problems with git, email, word wrapping & whitespaces.
(I ran into that a few years ago, and learned to use git send-mail to avoid problems caused by the mail client)

Now there is a new second version of the patch. Hopefully both LEDs get active this time.

https://patchwork.kernel.org/patch/10224335/
http://lists.infradead.org/pipermail/ath10k/2018-February/010820.html

1 Like

are you going to release a new master version with this patch?

I did compile a quick version for myself, but still no life in the 2.4GHz LED.

ok thanks for the reply pity that the LED still does not work

Now,there is even v4 of the patch
https://patchwork.kernel.org/patch/10225179/

You dont have to remove UBNT definitions as that is just rebranded QCA988X v2.
That was merged couple of days ago in order to drop OpenWRT patch for supporting that chip.